Allow a period in names of images uploaded to Wikimedia

[zstadler]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (2fe5d22) to head (1e81ccc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          93       93           
  Lines        8103     8103           
  Branches      985      985           
=======================================
  Hits         7401     7401           
  Misses        477      477           
  Partials      225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

I think the regexp for invalid characters needs to be replaced in order to solve this...
In any case, a test needs to be added to make sure this is working as expected...

[zstadler]

I think the regexp for invalid characters needs to be replaced in order to solve this...

a period is a valid character. For example: https://commons.wikimedia.org/wiki/File:0.10_Exhibition.jpg

[zstadler]

In any case, a test needs to be added to make sure this is working as expected...

Could you please take care of that

[HarelM]

WikiClientLibrary doesn't seem to have the relevant interfaces to be able to mock it properly.
I'll look into extracting the logic to a helper class that can be unit tested, hopefully...

[HarelM]

Replaced by:

• Allow a period in names of images uploaded to Wikimedia #2041