Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config conflicts for islandora_mirador #60

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fix config conflicts for islandora_mirador #60

wants to merge 1 commit into from

Conversation

elizoller
Copy link
Member

What does this Pull Request do?

remove references to field_access_terms which cause the module to fail to install

What's new?

Minor config changes that correspond to upstream changes in islandora_defaults

How should this be tested?

  • try to install islandora_mirador. watch it complain about missing access_terms config
  • pull in this PR
  • try to install islandora_mirador again. watch it succeed (i hope)

Interested parties

@Islandora/8-x-committers

seth-shaw-unlv
seth-shaw-unlv suggested changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some additional references to field_access_terms (in the hidden section). Can we remove those too, just to make it a bit cleaner?

P.S. Sorry for letting this sit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-unlv seth-shaw-unlv seth-shaw-unlv requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizoller @seth-shaw-unlv