Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing scaffolding plugin after install #177

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

dannylamb
Copy link
Member

GitHub Issue: Islandora/documentation#1448

What does this Pull Request do?

Removes the scaffolding plugin after install since it's being problematic and it's already done its job.

How should this be tested?

Without this PR, new environments fail when running composer require. If you pull in this PR and build a box, composer require commands should succeed.

Interested parties

@manez @DonRichards @Islandora-Devops/committers

@manez
Copy link
Contributor

manez commented Apr 20, 2020

Built with it this morning. Build went fine, but when I tried composer require drupal/views_bulk_edit, I get a new error:

Script @composer druapl:scaffold handling the post-update-cmd event returned with error code 1

@DonRichards
Copy link
Member

This is what I'm seeing Screen Shot 2020-04-20 at 3 29 24 PM

@manez
Copy link
Contributor

manez commented Apr 20, 2020

Geez. @DonRichards summoning eldritch horrors over here 🐙

@whikloj
Copy link
Member

whikloj commented Apr 21, 2020

Building this now as Centos

@dannylamb
Copy link
Member Author

@DonRichards I have ignore errors set on that. It was fussy to uninstall when I did it manually. 😼

@manez I think I may have built with my no-scaffolding branch of drupal-project, which might explain why I never saw that one. Do you have "@composer drupal:scaffold" in the post-install and post-update chunks of your site's composer.json?

@whikloj
Copy link
Member

whikloj commented Apr 21, 2020

I am seeing as above, huge ugly but ignored error. But when trying to install using composer getting

[vagrant@islandora8 drupal]$ composer require drupal/pathauto
Using version ^1.6 for drupal/pathauto
./composer.json has been updated
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Installing drupal/ctools (3.4.0): Downloading (100%)         
  - Installing drupal/pathauto (1.6.0): Downloading (100%)         
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package silex/silex is abandoned, you should avoid using it. Use symfony/flex instead.
Package zendframework/zend-diactoros is abandoned, you should avoid using it. Use laminas/laminas-diactoros instead.
Package zendframework/zend-escaper is abandoned, you should avoid using it. Use laminas/laminas-escaper instead.
Package zendframework/zend-feed is abandoned, you should avoid using it. Use laminas/laminas-feed instead.
Package zendframework/zend-stdlib is abandoned, you should avoid using it. Use laminas/laminas-stdlib instead.
Writing lock file
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

                                                                  
  [Symfony\Component\Console\Exception\CommandNotFoundException]  
  There are no commands defined in the "drupal" namespace.        
                                                                  

Script @composer drupal:scaffold handling the post-update-cmd event returned with error code 1

Installation failed, reverting ./composer.json to its original content.

Will try the drupal-project PR now.

@DonRichards
Copy link
Member

This is what I'm seeing when I try a simple $ composer update

Screen Shot 2020-04-21 at 3 10 58 PM

@dannylamb
Copy link
Member Author

I'm testing the changes I just pushed now. I'm using this PR plus I set drupal_composer_project_package: "islandora/drupal-project:dev-no-auto-scaffold" in inventory/vagrant/group_vars/webserver/drupal.yml`.

@dannylamb
Copy link
Member Author

total 🤦‍♂️, but i've fixed it and am trying again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants