Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the first version encountered in Cargo.toml #82

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented Jan 14, 2025

Won't increment other top level version lines (for dependencies etc).

Testable locally by running bump-version.set.sh 1.0.0 against the test project to confirm current behavior. Then re-check out and manually edit Cargo.toml to have another version = "3.0.0" in it at the top level. Run it again, and see that it still only changes the first value to 1.0.0.

Won't increment other top level version lines (for dependencies etc)
@skeet70 skeet70 requested a review from giarc3 January 14, 2025 23:18
@skeet70 skeet70 requested a review from a team as a code owner January 14, 2025 23:18
Copy link

File Coverage Lines
All files 0% 0%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 04d5aa5

Copy link
Member

@giarc3 giarc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Worked for me locally

@skeet70 skeet70 merged commit ab70325 into main Jan 14, 2025
13 checks passed
@skeet70 skeet70 deleted the cargo-match-first-version-only branch January 14, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants