Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rondpoint types #3

Merged
merged 23 commits into from
May 28, 2024
Merged

Implement rondpoint types #3

merged 23 commits into from
May 28, 2024

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented May 24, 2024

No description provided.

skeet70 added 16 commits May 17, 2024 12:50
@skeet70
Add byte/UInt8/Int8 types, add start of rondpoint
70c3336 
Also updates to current main of uniffi, removing `BindingsConfig` struct
@skeet70
Add more numeric primitives, object
f927f70
@skeet70
Optionals and Sequences
42be978
@skeet70
Map and Record
8c23f9f 
(and actually sequence and optional, forgot to add before)

Now generating but not compiling on the Java side yet
@skeet70
Add object cleaners, fix broken Java
b9f1bfa
@skeet70
Generate record files
d4a592b
@skeet70
More compiling Maps, Sequences, Enums
153cc5d 
Still missing Optional FfiConverters from the generation for some reason
@skeet70
Compiling, following test failures
31ed84a
@skeet70
Working minimal rondpoint test!
42ae4f3
@skeet70
All tested and passing except optional defaults.
40ad041 
Need to settle on how we want to handle default parameters.
@skeet70
Commit to no defaults
457b1a3
@skeet70
Add JNA to flake
0665055
@skeet70
Add to testing doc
c3119b4
@skeet70
Clear up a bunch of the TODOs that were decided
eb9c369
@skeet70
Going with immutable records by default
3cc717a
@skeet70
Add geometry example test
1649ad6
coltfred
coltfred approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all pretty opaque to me, but the test suite is pretty nice and comprehensive. I think it's a good place to start!

src/lib.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

File Coverage Lines
All files 63% 63% ✅
src/lib.rs 54% 54% ✅
src/gen_java/compounds.rs 78% 78% ✅
src/gen_java/mod.rs 69% 69% ✅
src/gen_java/primitives.rs 11% 11% ✅

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 1677f89

@skeet70 skeet70 merged commit f0450c5 into main May 28, 2024
7 checks passed
@skeet70 skeet70 deleted the implement-rondpoint-types branch May 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skeet70 @coltfred