Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craig test 2 #27

Closed
wants to merge 34 commits into from
Closed

Craig test 2 #27

wants to merge 34 commits into from

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Aug 7, 2024

No description provided.

skeet70 and others added 29 commits July 24, 2024 10:59
so I can copy them later if needed
What if the logic is fine but the Java FFI is slow, so the delay
finishes before the call from Rust gets back for it to await the
abortable?
and wait longer than the times we're seeing in CI on the delay. The free
is still being called, so nothing looks like it's leaking, but it is way
slower than expected vs local (or even passing CI runs, which were
faster than local)
Try extending the delay a bunch
Right now when it works in CI the free happens ~1.3ms after the call to
the delay trait (which makes sense given the 1ms delay in Rust before it
aborts). When it doesn't work though the free doesn't happen until ~.6ms
after the delay call fully finishes, so 100.5ms after the call to the
delay trait. It seems like a bug where the FreeImpl isn't being called
from Rust in time, but I want to see if bumping the delay to 200ms
results in 1.3/200.5, or 1.3/100.5 still
Copy link

github-actions bot commented Aug 7, 2024

File Coverage Lines
All files 77% 77%
src/lib.rs 54% 54%
src/gen_java/mod.rs 88% 88%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 8a14d1c

@giarc3 giarc3 closed this Aug 8, 2024
@giarc3 giarc3 deleted the craig-test-2 branch August 8, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants