Polish before alpha #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeet70
requested review from
giarc3 and
coltfred
and removed request for
a team and
giarc3
so I can copy them later if needed
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against af6eb00 |
skeet70
force-pushed
the
polish-before-alpha
branch
from
c7104a3 to
0881859
Compare
What if the logic is fine but the Java FFI is slow, so the delay finishes before the call from Rust gets back for it to await the abortable?
and wait longer than the times we're seeing in CI on the delay. The free is still being called, so nothing looks like it's leaking, but it is way slower than expected vs local (or even passing CI runs, which were faster than local)
Try extending the delay a bunch
Right now when it works in CI the free happens ~1.3ms after the call to the delay trait (which makes sense given the 1ms delay in Rust before it aborts). When it doesn't work though the free doesn't happen until ~.6ms after the delay call fully finishes, so 100.5ms after the call to the delay trait. It seems like a bug where the FreeImpl isn't being called from Rust in time, but I want to see if bumping the delay to 200ms results in 1.3/200.5, or 1.3/100.5 still
We can't trust Java's `CompletableFuture` to wake a suspended thread correctly when the `CompletableFuture` being blocked on is `complete()`, so we're manually busy waiting the futures thread for now.
skeet70
force-pushed
the
polish-before-alpha
branch
from
382ab7c to
5f7f2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.