Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required small changes to uniffi to thread all the external values we needed for a fully qualified
RustBuffer
through. Also some big changes to our code to threadconfig
through basically all over the place to support fully qualified external types.This also prompted that for subdependencies we can't do the
uniffi.toml
extension trick we've been doing in the tests (seecustom_types
usage inTestImportedTypes
. I wrote up a failed attempt at doing something similar in the branchfailed-rewrite-uniffi-toml-dep
, but the overwritten values aren't used in the build and we don't have a way to manually pass the overrides down to subdependencies like we are for the top level fixtures with ourgenerate_bindings
call. For now I just changed the tests to not expect the niceURL
swapping to work, but long term hopefully there's a better way.