Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes chrono and usages of DateTime<Utc> and replaces them withtime::OffsetDateTime #249

Merged
merged 7 commits into from
Nov 23, 2021
Merged

Removes chrono and usages of DateTime<Utc> and replaces them withtime::OffsetDateTime #249

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b989a0c
Removes `chrono` and usages of `DateTime<Utc>` and replaces them wi…
clintfred Nov 19, 2021
d701bed
depend on our fork of jsonwebtoken
clintfred Nov 19, 2021
ca7ceb0
cargo fmt
clintfred Nov 19, 2021
71ea4b2
lock to specific rev on jsonwebtoken fork
clintfred Nov 19, 2021
6fd11f7
self review changes
clintfred Nov 19, 2021
03e39dd
Merge remote-tracking branch 'origin/main' into 244-time-types
clintfred Nov 22, 2021
e79ca25
Update to new jsonwebtoken
coltfred Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 0.27.0 (Unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start putting dates on the changelog entries.
Also, any reason to not release this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily disagreeing on adding the changelog dates, but the canonical information for release-dates is available from crates.io via

curl 'https://crates.io/api/v1/crates/ironoxide'

As for release - I think it's fine to release this whenever, but we should merge this PR first and then follow https://github.com/IronCoreLabs/ironoxide/blob/main/RELEASING.md
If we want to start adding dates in CHANGELOG.md, adding it to the release checklist would be the right place.

- [[#249](https://github.com/IronCoreLabs/ironoxide/pull/249)] Remove `chrono` types in public API and replace with equivalent `time` types.

## 0.26.0

- [[#243](https://github.com/IronCoreLabs/ironoxide/pull/243)] Add `#[non_exhaustive]` to IronOxideErr.
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ironoxide"
version = "0.26.0"
version = "0.27.0"
authors = [ "IronCore Labs <[email protected]>" ]
readme = "README.md"
license = "AGPL-3.0-only"
Expand All @@ -27,7 +27,7 @@ futures = "0.3.1"
hex = "0.4"
ironcore-search-helpers = { version = "0.1.2", optional = true }
itertools = "0.10"
jsonwebtoken = "7.2"
jsonwebtoken = { git = "https://github.com/IronCoreLabs/jsonwebtoken" }
clintfred marked this conversation as resolved.
Show resolved Hide resolved
lazy_static = "1.4"
log = "0.4"
percent-encoding = "2.1"
Expand Down