Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on publicsuffix #232

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Remove dependency on publicsuffix #232

merged 2 commits into from
Mar 15, 2021

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Mar 15, 2021

As discovered in #231, we were only using publicsuffix for the IntoUrl trait. Instead, we can just call url::Url::parse directly ourselves.

clintfred
clintfred approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giarc3 giarc3 merged commit cf22d61 into main Mar 15, 2021
@giarc3 giarc3 deleted the remove-publicsuffix branch March 15, 2021 22:49
giarc3 added a commit that referenced this pull request May 6, 2021
@giarc3
v0.25.2
05ff0e9 
- [[#222](#222)] Loosen version requirements for dependencies.
- [[#225](#225)] Fix bug causing requests with empty policies to fail.
- [[#232](#232)] Remove dependency on publicsuffix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintfred clintfred clintfred approved these changes

@BobWall23 BobWall23 BobWall23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giarc3 @BobWall23 @clintfred