Removes chrono and usages of DateTime<Utc> and replaces them withtime::OffsetDateTime
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`time::OffsetDateTime`. This change should not have any semantic meaning and is being done to address RUSTSEC-2020-0071 (see #244) and RUSTSEC-20200159 (see #245). This is a breaking API change because some result types include create/updated timestamps. Consumers of the library will need to add a direct dependency on `time`. Note that `chrono` already uses `time` internally, so this change should not bloat transitive dependencies. For those needing serialization support of `OffsetDateTime` timestamps, the `time` crate offers this support with the `serde` feature flag. One small point of friction here is rfc3339 support. `time` has this support on [a branch](time-rs/time#387) that is blocked on a rust feature hitting stable, so I copied in a few lines of code from that branch to support deserializing rfc3339 timestamps.
giarc3
reviewed
Nov 19, 2021
clintfred
commented
Nov 19, 2021
BobWall23
requested changes
Nov 22, 2021
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## 0.27.0 (Unreleased) | |||
There was a problem hiding this comment.
Let's start putting dates on the changelog entries.
Also, any reason to not release this?
There was a problem hiding this comment.
Not necessarily disagreeing on adding the changelog dates, but the canonical information for release-dates is available from crates.io via
curl 'https://crates.io/api/v1/crates/ironoxide'
As for release - I think it's fine to release this whenever, but we should merge this PR first and then follow https://github.com/IronCoreLabs/ironoxide/blob/main/RELEASING.md
If we want to start adding dates in CHANGELOG.md, adding it to the release checklist would be the right place.
coltfred
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244 #245
This change should not have any semantic meaning and is being done to address RUSTSEC-2020-0071 (see #244) and RUSTSEC-20200159 (see #245).
This is a breaking API change because some result types include create/updated timestamps. Consumers of the library will need to add a direct dependency on
time. Note thatchronoalready usestimeinternally, so this change should not bloat transitive dependencies.For those needing serialization support of
OffsetDateTimetimestamps, thetimecrate offers this support with theserdefeature flag.One small point of friction here is rfc3339 support.
timehas this support on a branch that is blocked on a rust feature hitting stable, so I copied in a few lines of code from that branch to support deserializing rfc3339 timestamps.To fully fix the RUSTSEC advisories, it was necessary to upgrade one of our dependencies as well.
See Keats/jsonwebtoken#222
For now, this PR depends on https://github.com/IronCoreLabs/jsonwebtoken.