Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publicsuffix can be dropped #231

Closed
rushmorem opened this issue Mar 14, 2021 · 2 comments
Closed

publicsuffix can be dropped #231

rushmorem opened this issue Mar 14, 2021 · 2 comments
Assignees
@giarc3
Labels
tech debt
Milestone
2021-03-28

Comments

@rushmorem
Copy link

It seems like this crate is only using publicsuffix to take advantage of publicsuffix::IntoUrl trait. This trait is no longer available in v2 of the crate. You can use url::Url::parse instead and drop publicsuffix entirely.
@clintfred clintfred added this to the 2021-03-28 milestone Mar 15, 2021
@clintfred
Copy link
Contributor

@rushmorem Thanks for the heads up. Direct usage of url works great.

@rushmorem
Copy link
Author

You are welcome :)

@giarc3 giarc3 mentioned this issue Mar 15, 2021
Merged
@giarc3 giarc3 self-assigned this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giarc3 giarc3

Labels
tech debt
Projects
None yet
Milestone
2021-03-28
Development

No branches or pull requests
3 participants
@rushmorem @clintfred @giarc3