Fix hard coded vertex format element IDs #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erdragh
force-pushed
the
fix/vertex-format-element-ids
branch
from
ddb584e to
e302169
Compare
|
Looks good to me at first glance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the registration of the
VertexFormatElements to not use hardcoded IDs and instead tries to fit the IDs into gaps of the ID -> VFE mapping.This prevents crashes on startup with other mods that handle new
VertexFormatElements the same way (i.e. Stellar View), which would previously try to register with IDs that were already taken by Iris.Fixes #2491