Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPLC] [Test] Add scoping tests #6773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UPLC] [Test] Add scoping tests #6773

wants to merge 1 commit into from

Conversation

effectfully
Copy link
Contributor

@effectfully effectfully commented Jan 6, 2025 •
edited
Loading

This adds scoping tests for UPLC the same way we have them for PIR. It also tweaks the way the scoping machinery handles case-expressions for PIR.

I didn't stumble upon any unexpected behavior.

@effectfully effectfully self-assigned this Jan 6, 2025
@effectfully effectfully added the No Changelog Required Add this to skip the Changelog Check label Jan 6, 2025
@effectfully effectfully force-pushed the effectfully/untyped-plutus-core/test/add-scoping branch from 31e82d6 to 95bbea6 Compare January 6, 2025 10:00
@effectfully effectfully force-pushed the effectfully/untyped-plutus-core/test/add-scoping branch from 95bbea6 to cf7c231 Compare January 6, 2025 10:42
@effectfully effectfully requested review from Unisay and zliu41 January 6, 2025 11:12
zliu41
zliu41 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but we have a Pass data type (though currently only for PIR) where a Pass is associated with pre- and post-conditions. Would it be better to express the scoping properties in Pass instead of using this more ad-hoc way of testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliu41 zliu41 zliu41 approved these changes

@Unisay Unisay Awaiting requested review from Unisay

Assignees

@effectfully effectfully

Labels
Name handling No Changelog Required Add this to skip the Changelog Check Test Untyped Plutus Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @zliu41