[Builtins] Add the 'dropList' builtin #6468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
Do not merge
Builtins
EXPERIMENT
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
017e9d4
to
df4dea7
Compare
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
df4dea7
to
7be8e1f
Compare
…to effectfully/builtins/add-dropList
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
7be8e1f
to
e22a57b
Compare
…to effectfully/builtins/add-dropList
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
16db02d
to
41ea9b6
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
kwxm
reviewed
Oct 30, 2024
| @@ -1557,6 +1558,18 @@ instance uni ~ DefaultUni => ToBuiltinMeaning uni DefaultFun where | |||
| nullListDenotation | |||
| (runCostingFunOneArgument . paramNullList) | |||
|
|
|||
| toBuiltinMeaning _semvar DropList = | |||
| let dropListDenotation :: Int -> SomeConstant uni [a] -> BuiltinResult (Opaque val [a]) | |||
There was a problem hiding this comment.
The time taken for this will probably be linear in the value (not the size!) of the first argument. That'll mean susing some newtype wrapper, like this . We already have IntegerCostedLiterally, but this has an Int so that may need another wrapper.
There was a problem hiding this comment.
^ @ramsay-t FYI
but this has an
Intso that may need another wrapper.
Actually, why did I even make it Int, what's the point? Looks like a thinko.
There was a problem hiding this comment.
The time taken for this will probably be linear in the value (not the size!) of the first argument.
No, I think it's gonna be a minimum of
- linear in the value of the first argument
- linear in the length of the second argument
since drop maxBound [] equals [].
There was a problem hiding this comment.
Actually, why did I even make it
Int, what's the point? Looks like a thinko.
It's proper Integer in there now.
There was a problem hiding this comment.
No, I think it's gonna be a minimum of
linear in the value of the first argument
linear in the length of the second argument
since drop maxBound [] equals [].
I deliberately ignored that case! If we include the length of the list in the cost calculation then we'll have to traverse the entire list to measure the length when we're about to calculate the cost, and that'll slow things down. If we just base it on the number of things we want to drop then we'll still get a conservative estimate of the cost, and it'll be faster. Also, if you drop the whole of the list then you've probably done something wrong, and people probably won't submit scripts where that actually happens (or at least not often).
There was a problem hiding this comment.
Oh I see. OK, that's clever. Yeah, I think I agree, although I'd perhaps prefer to store lists together with their length, although that'd perhaps slow everything else down. Fair enough!
@ramsay-t ignore what I said and only consider the original comment in this thread.
There was a problem hiding this comment.
I'd perhaps prefer to store lists together with their length
I've wondered about doing that in the past (and maybe something similar with Data for instance), but what happens if someone lies about the length of a list in their script? Maybe that could be checked during deserialisation ...
| @@ -82,6 +82,7 @@ module PlutusTx.Builtins ( | |||
| , headMaybe | |||
| , BI.head | |||
| , BI.tail | |||
| , BI.drop | |||
There was a problem hiding this comment.
Should this also go in PlutusTx.Prelude? I seem to remember that the contents of that file are kind of random though.
| @@ -408,6 +409,10 @@ chooseList :: BuiltinList a -> b -> b -> b | |||
| chooseList (BuiltinList []) b1 _ = b1 | |||
| chooseList (BuiltinList (_:_)) _ b2 = b2 | |||
|
|
|||
| {-# OPAQUE drop #-} | |||
| drop :: Integer -> BuiltinList a -> BuiltinList a | |||
There was a problem hiding this comment.
Why not dropList? So that it just replaces the Haskell version with minimal effort from the user?
There was a problem hiding this comment.
For consistency, we also have head (and not headList) and tail (and not tailList) in this file.
…to effectfully/builtins/add-dropList
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
f999164
to
e8c0b9d
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ac8c225aeb' (base) and 'd36d0f87f4' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ac8c225aeb' (base) and 'd36d0f87f4' (PR) Results table
|
|
/benchmark validation |
1 similar comment
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ac8c225aeb' (base) and 'd36d0f87f4' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ac8c225aeb' (base) and 'd36d0f87f4' (PR) Results table
|
Oh, come on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experiment adds the
dropListbuiltin so that folks can play with it. Not intended for merging.