Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chainsync timeout #4472

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Mar 28, 2023

Increase the minimum timeout from 90s to 135s and switch from picking from an array of 5 values to a range of timeouts.
This change reduces the risk of synchronosation among nodes in the network.

Description

description of the pull request, if it fixes a particular issue it should link the PR to a particular issue, see ref

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
    • Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers. If deprecating a whole module, remember to add it to ./scripts/ci/check-stylish.sh as otherwise stylish-haskell would un-deprecate it.
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@karknu
Copy link
Contributor Author

karknu commented Mar 28, 2023

I don't have permission to add reviewers but this change should be reviewed by @coot , @njd42 .

@bolt12 bolt12 requested review from coot and njd42 March 28, 2023 09:17
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Increase the minimum timeout from 90s to 135s and switch from picking
from an array of 5 values to a range of timeouts.
This change reduces the risk of synchronosation among nodes in the
network.
@karknu karknu force-pushed the karknu/chainsync_timeout_m branch from 05a573d to c02b1df Compare April 3, 2023 11:40
@coot coot added the networking label Apr 5, 2023
@coot
Copy link
Contributor

coot commented Apr 5, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 5, 2023

@iohk-bors iohk-bors bot merged commit 6285f0f into IntersectMBO:master Apr 5, 2023
@karknu karknu deleted the karknu/chainsync_timeout_m branch April 5, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants