Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate checksums in openWriteBuffer #542

Merged
merged 4 commits into from
Jan 29, 2025
Merged

fix: validate checksums in openWriteBuffer #542

merged 4 commits into from
Jan 29, 2025

Conversation

wenkokke
Copy link
Collaborator

@wenkokke wenkokke commented Jan 22, 2025 •
edited
Loading

Should be merged after #539

@wenkokke wenkokke marked this pull request as draft January 22, 2025 15:28
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch 2 times, most recently from bb85455 to 54bf917 Compare January 22, 2025 15:37
@wenkokke wenkokke mentioned this pull request Jan 22, 2025
Closed
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch 8 times, most recently from cbc3ff0 to ef58760 Compare January 28, 2025 14:18
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch from ef58760 to 854c8a7 Compare January 28, 2025 14:19
@wenkokke wenkokke marked this pull request as ready for review January 28, 2025 14:19
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch from 854c8a7 to c45a421 Compare January 28, 2025 14:30
jorisdral
jorisdral approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@jorisdral jorisdral left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

I have some small suggestions, but we can merge once they are resolved. We can probably also squash a few of the commits together

src/Database/LSMTree/Internal/Paths.hs Show resolved Hide resolved
src/Database/LSMTree/Internal/Paths.hs Outdated Show resolved Hide resolved
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch from c45a421 to 706eb72 Compare January 29, 2025 13:22
@wenkokke wenkokke force-pushed the wenkokke/corrupt-snapshot-wb branch from 706eb72 to 1cc5921 Compare January 29, 2025 13:24
@wenkokke wenkokke enabled auto-merge January 29, 2025 13:24
@jorisdral jorisdral linked an issue Jan 29, 2025 that may be closed by this pull request
[BUG] Verify write buffer checksum when loading snapshot #525
Closed
3 tasks
@wenkokke wenkokke added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@wenkokke wenkokke added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 0036a87 Jan 29, 2025
27 checks passed
@wenkokke wenkokke deleted the wenkokke/corrupt-snapshot-wb branch January 29, 2025 18:15
@jorisdral jorisdral mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisdral jorisdral jorisdral approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@mheinzel mheinzel Awaiting requested review from mheinzel mheinzel is a code owner

@recursion-ninja recursion-ninja Awaiting requested review from recursion-ninja recursion-ninja is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Verify write buffer checksum when loading snapshot
2 participants
@wenkokke @jorisdral