Make BlobFile functions exception safe
#520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/fault-test-blobfile
branch
from
c444b15 to
a869832
Compare
jorisdral
force-pushed
the
jdral/fault-test-blobfile
branch
from
a869832 to
0fe4ac4
Compare
jorisdral
commented
Jan 14, 2025
Comment on lines
+74
to
+77
| -- TODO: this function takes ownership of the file path. The file is | ||
| -- removed when the blob file is finalised, which may lead to | ||
| -- surprise errors when the file is also deleted elsewhere. Maybe | ||
| -- file paths should be guarded by 'Ref's as well? |
There was a problem hiding this comment.
This is something I might know how to fix, but don't want to spend too much time on now because it requires more elaborate changes to the code. I'll leave it as a TODO and address it in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.