Make headerLBS and finalLBS index-type-polymorphic
#483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
dcoutts,
jorisdral,
mheinzel and
recursion-ninja
as code owners
jeltsch
changed the title
postVersionBytes to postTypeAndVersionBytesheaderLBS and finalLBS index-type-polymorphic
jorisdral
reviewed
Dec 5, 2024
jeltsch
force-pushed
the
jeltsch/polymorphic-index-periphery
branch
from
42bbe9a to
b744e2d
Compare
jorisdral
approved these changes
Dec 9, 2024
jeltsch
force-pushed
the
jeltsch/polymorphic-index-periphery
branch
from
b744e2d to
0d0eab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generation of headers and footers of serialized indexes has so far been working only for compact indexes. This pull request introduces an implementation of this functionality for ordinary indexes and extends the
Indextype class such that header and footer generation can be accessed independently of the concrete index type.As a side change, this pull request also corrects the naming of
postVersionBytes, an entity local to thefromSBSdefinition forIndexOrdinary, topostTypeAndVersionBytes.