Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Report 275 failing test #2834

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Fix : Report 275 failing test #2834

merged 12 commits into from
Jan 30, 2025

Conversation

kneerose
Copy link
Contributor

List of changes

  • Update the fetch logic for the first dRep filter to exclude script-based dReps, as they cause issues displaying the dRep ID on the dRep card.
  • Update dRep assertions to include the CIP-105 prefix.
  • Use the wallet address to generate the payment address for dReps.
  • Update the proposal discussion link.
  • Fix the issue with user snap URL interception.
  • Increase the timeout for assertions.
  • Use env networkId instead of hardcoded zero to get the address from wallet
  • fix crypto not found issue
  • generate wallet address according to environment network
  • use stake address on proposal creation form instead of wallet address

Checklist

  • related report
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Copy link

✅ All checks succeeded

2 similar comments
Copy link

✅ All checks succeeded

Copy link

✅ All checks succeeded

@kneerose kneerose merged commit 31a3821 into develop Jan 30, 2025
10 of 12 checks passed
@kneerose kneerose deleted the fix/report-275-failing-test branch January 30, 2025 09:40
Copy link

@kneerose
This PR is in the tag: develop-31a3821166aa821611b1a8a8b11650726422ffbd , for govtool-frontend service

Copy link

@kneerose
This PR is in the tag: develop-31a3821166aa821611b1a8a8b11650726422ffbd , for govtool-metadata-validation service

Copy link

@kneerose
This PR is in the tag: develop-31a3821166aa821611b1a8a8b11650726422ffbd , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants