Merge pull request #2402 from IntersectMBO/tests/assert-govActionId

Assert CIP129 and govActionId on governance action details page

tests/govtool-frontend/playwright/lib/helpers/computeTxHash.ts

@@ -1,5 +1,5 @@
 import { blake2bHex } from "blakejs";
-import { cborxDecoder, cborxEncoder } from "./cborEncodeDecode";
+import { cborxDecoder, cborxEncoder } from "./encodeDecode";
 
 export default function computeTxHash(tx: string) {
   let decodedTx = cborxDecoder.decode(Buffer.from(tx, "hex"));

tests/govtool-frontend/playwright/lib/helpers/encodeDecode.ts

@@ -0,0 +1,22 @@
+import { bech32 } from "bech32";
+import { Decoder, Encoder } from "cbor-x";
+
+export const cborxEncoder = new Encoder({
+  mapsAsObjects: false,
+  useRecords: false,
+});
+export const cborxDecoder = new Decoder({ mapsAsObjects: false });
+
+export const encodeCIP129Identifier = ({
+  txID,
+  index,
+  bech32Prefix,
+}: {
+  txID: string;
+  index?: string;
+  bech32Prefix: string;
+}) => {
+  const govActionBytes = Buffer.from(index ? txID + index : txID, "hex");
+  const words = bech32.toWords(govActionBytes);
+  return bech32.encode(bech32Prefix, words);
+};

tests/govtool-frontend/playwright/lib/services/kuberService.ts

@@ -9,7 +9,7 @@ import * as blake from "blakejs";
 import environments from "lib/constants/environments";
 import { LockInterceptor, LockInterceptorInfo } from "lib/lockInterceptor";
 import fetch, { BodyInit, RequestInit } from "node-fetch";
-import { cborxDecoder, cborxEncoder } from "../helpers/cborEncodeDecode";
+import { cborxDecoder, cborxEncoder } from "../helpers/encodeDecode";
 import { Logger } from "@helpers/logger";
 
 type CertificateType = "registerstake" | "registerdrep" | "deregisterdrep";

tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts

@@ -5,6 +5,7 @@ import { faker } from "@faker-js/faker";
 import { test } from "@fixtures/walletExtension";
 import { setAllureEpic } from "@helpers/allure";
 import { isBootStrapingPhase, skipIfNotHardFork } from "@helpers/cardano";
+import { encodeCIP129Identifier } from "@helpers/encodeDecode";
 import { createNewPageWithWallet } from "@helpers/page";
 import { waitForTxConfirmation } from "@helpers/transaction";
 import GovernanceActionDetailsPage from "@pages/governanceActionDetailsPage";
@@ -25,11 +26,13 @@ test.describe("Proposal checks", () => {
   test.use({ storageState: ".auth/dRep01.json", wallet: dRep01Wallet });
 
   let govActionDetailsPage: GovernanceActionDetailsPage;
+  let currentPage: Page;
 
   test.beforeEach(async ({ page }) => {
     const govActionsPage = new GovernanceActionsPage(page);
     await govActionsPage.goto();
 
+    currentPage = page;
     govActionDetailsPage = (await isBootStrapingPhase())
       ? await govActionsPage.viewFirstProposalByGovernanceAction(
           GrovernanceActionType.InfoAction
@@ -38,9 +41,27 @@ test.describe("Proposal checks", () => {
   });
 
   test("5A. Should show relevant details about governance action as DRep", async () => {
+    const governanceActionIdWithIndex = currentPage.url().split("/").pop();
+    const governanceActionId = governanceActionIdWithIndex.substring(0, 64);
+
+    const cip129GovActionId = encodeCIP129Identifier({
+      txID: governanceActionId,
+      index: governanceActionIdWithIndex
+        .replace(`${governanceActionId}#`, "")
+        .toString()
+        .padStart(2, "0"),
+      bech32Prefix: "gov_action",
+    });
+
     await expect(govActionDetailsPage.governanceActionType).toBeVisible();
     await expect(govActionDetailsPage.submittedDate).toBeVisible();
     await expect(govActionDetailsPage.expiryDate).toBeVisible();
+    await expect(
+      currentPage.getByTestId(`${governanceActionIdWithIndex}-id`)
+    ).toBeVisible();
+    await expect(
+      currentPage.getByTestId(`${cip129GovActionId}-id`)
+    ).toBeVisible();
 
     await expect(govActionDetailsPage.contextBtn).toBeVisible();
     await expect(govActionDetailsPage.showVotesBtn).toBeVisible();