Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate delegation related endpoints to delegation pillar backend #8

Merged
merged 3 commits into from
Oct 30, 2024
Merged

feat: migrate delegation related endpoints to delegation pillar backend #8

merged 3 commits into from
Oct 30, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Oct 28, 2024

  • ada holder service should be ok
  • list-dreps is just a start and needs more work
  • get-network-metrics and get-drep-info are missing

@jdyczka jdyczka marked this pull request as draft October 28, 2024 09:57
@MSzalowski MSzalowski marked this pull request as ready for review October 29, 2024 00:00
@MSzalowski
Copy link
Contributor

get-network-metrics is not part of this pillar. That is already implemented on the top wrapper level

@MSzalowski
Copy link
Contributor

ada holder service should be ok

I've updated ada holder service as query were used instead of params

@MSzalowski MSzalowski changed the title feat/ migrate backend feat: migrate delegation related endpoints to delegation pillar backend Oct 29, 2024
@MSzalowski MSzalowski self-requested a review October 30, 2024 08:11
@MSzalowski MSzalowski merged commit a79f753 into develop Oct 30, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdyczka @MSzalowski @j-dyczka