Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check for ccreghot #506

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

WhatisRT
Copy link
Collaborator

Description

Closes #490. We only want to merge this once conformance tests can detect this test failing.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@WhatisRT WhatisRT changed the title DO NOT MERGE: Add additional check for ccreghot Add additional check for ccreghot Oct 29, 2024
@WhatisRT WhatisRT linked an issue Jan 8, 2025 that may be closed by this pull request
plus many mods required to reconcile and type-check the result of
merge conflict resolution
@williamdemeo
Copy link
Contributor

williamdemeo commented Jan 13, 2025

@teodanciu I did my best to rebase this very old PR and reconcile the conflicts and then revise the resulting merge so that it type-checks. However, I think @WhatisRT should probably have a look at it again before we merge so that he can make sure I haven't messed it up or reverted any changes that he wants to keep.

In the meantime, you can run your conformance tests off the MAlonzo branch that gets generated from this branch once the CI passes.

@WhatisRT WhatisRT merged commit 14803ec into master Jan 14, 2025
9 checks passed
@WhatisRT WhatisRT deleted the andre/add-ccreghot-check branch January 14, 2025 14:15
github-actions bot added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants