Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style guide for the PDF #267

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add style guide for the PDF #267

merged 2 commits into from
Oct 30, 2023

Conversation

WhatisRT
Copy link
Collaborator

@WhatisRT WhatisRT commented Oct 25, 2023 •
edited
Loading

Description

A style guide for the PDF. Feedback welcome.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

williamdemeo
williamdemeo reviewed Oct 25, 2023
View reviewed changes
PDF-style-guide.md Outdated Show resolved Hide resolved
williamdemeo
williamdemeo approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one minor suggestion in the PR's "Conversation," but otherwise it looks good.

omelkonian
omelkonian requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, except the non-FP perspective which does not sit well with me.

PDF-style-guide.md Outdated Show resolved Hide resolved
@WhatisRT WhatisRT force-pushed the andre/pdf-style-guide branch from e300e23 to 76d7372 Compare October 26, 2023 12:10
omelkonian
omelkonian approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omelkonian omelkonian merged commit c69f593 into master Oct 30, 2023
3 checks passed
@omelkonian omelkonian deleted the andre/pdf-style-guide branch October 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdemeo williamdemeo williamdemeo approved these changes

@omelkonian omelkonian omelkonian approved these changes

@polinavino polinavino Awaiting requested review from polinavino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhatisRT @williamdemeo @omelkonian