Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update hlint GitHub CI workflow #6077

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

neilmayhew
Copy link
Contributor

Description

GitHub just updated the ubuntu-latest runner image from 22.04 to 24.04 and libtinfo5 is no longer in the image. However, the binary releases of hlint that are used no longer require libtinfo at any version.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@neilmayhew neilmayhew requested review from a team as code owners January 16, 2025 23:08
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neilmayhew neilmayhew enabled auto-merge January 16, 2025 23:51
@neilmayhew neilmayhew added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 6308039 Jan 17, 2025
114 of 121 checks passed
@neilmayhew neilmayhew deleted the nm/hlint-workflow branch January 17, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants