Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-ledger-conway-1.17.4 and cardano-node-10.1.4 #6064

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

neilmayhew
Copy link
Contributor

Description

Cherry-pick the changes from release/10.1.4

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@neilmayhew neilmayhew requested review from a team as code owners January 3, 2025 00:35
@neilmayhew neilmayhew requested review from crocodile-dentist, disassembler and Jimbo4350 and removed request for a team January 3, 2025 00:36
@neilmayhew
Copy link
Contributor Author

neilmayhew commented Jan 4, 2025

There's a failing testnet test on Hydra. It's in "Propose And Ratify New Constitution" and I assume the change in cardano-ledger-conway-1.17.4 has broken it. Would somebody be able to take a look at this, please?

@neilmayhew neilmayhew force-pushed the neilmayhew/cardano-ledger-conway-1.17.4 branch from 6851a76 to a6e8288 Compare January 6, 2025 14:34
@neilmayhew
Copy link
Contributor Author

There's a failing testnet test on Hydra. It's in "Propose And Ratify New Constitution" and I assume the change in cardano-ledger-conway-1.17.4 has broken it. Would somebody be able to take a look at this, please?

It passed after re-running in Hydra but the status didn't get back to GitHub. I've forced a re-run with git commit --amend --no-edit.

@neilmayhew neilmayhew enabled auto-merge January 6, 2025 14:57
@neilmayhew neilmayhew added this pull request to the merge queue Jan 6, 2025
Merged via the queue into master with commit 1774c93 Jan 6, 2025
114 of 121 checks passed
@neilmayhew neilmayhew deleted the neilmayhew/cardano-ledger-conway-1.17.4 branch January 6, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants