Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wb | voting workload #6062

Merged
merged 6 commits into from
Jan 10, 2025
Merged

wb | voting workload #6062

merged 6 commits into from
Jan 10, 2025

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Dec 30, 2024

Description

New "voting" workload

  • "development-voting" profile to run locally using the nomad local backend (make development-voting-nomadexec)
  • Perf cluster "voting" profiles, new workload on top of "value" and "plutus"
  • New profile "workloads" stanza used by "latency" and "voting". I allows to create custom workloads and easily add them to a profile.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the fmaste/voting branch 6 times, most recently from 20c9155 to 0a670d1 Compare January 3, 2025 11:46
@fmaste fmaste force-pushed the fmaste/voting branch 6 times, most recently from 33b3b6a to 9333f23 Compare January 7, 2025 17:37
@fmaste fmaste marked this pull request as ready for review January 7, 2025 18:34
@fmaste fmaste requested review from a team as code owners January 7, 2025 18:34
@fmaste fmaste changed the title Fmaste/voting wb | voting workload Jan 9, 2025
@mgmeier mgmeier mentioned this pull request Jan 9, 2025
9 tasks
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thourough work, thank you @fmaste

@mgmeier mgmeier added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 10, 2025
@fmaste fmaste added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit a5cd0b8 Jan 10, 2025
114 of 122 checks passed
@fmaste fmaste deleted the fmaste/voting branch January 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants