Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the CLI's "query proposals" command #6045

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Test the CLI's "query proposals" command #6045

merged 3 commits into from
Jan 14, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 29, 2024 •
edited by palas
Loading

Description

Tests the CLI's new "query proposals" command i.e. these PRs:

  1. Implement command "query proposals" cardano-cli#984
  2. Integrate query proposals cardano-api#684

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
  • Self-reviewed the diff

This was referenced Nov 29, 2024
Merged
Closed
@carbolymer carbolymer mentioned this pull request Dec 27, 2024
Merged
@carbolymer carbolymer mentioned this pull request Jan 10, 2025
Open
9 tasks
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 14, 2025
@smelc
Copy link
Contributor Author

smelc commented Jan 14, 2025

This work is being picked up by @palas

@palas palas self-assigned this Jan 14, 2025
@palas
Copy link
Contributor

palas commented Jan 14, 2025

Backed up here: backup/smelc/test-query-proposals

@palas palas force-pushed the smelc/test-query-proposals branch from cd80e0d to 77e70ca Compare January 14, 2025 12:23
@palas palas changed the base branch from master to utxo-hd-main January 14, 2025 12:23
@palas palas force-pushed the smelc/test-query-proposals branch 2 times, most recently from b15d5c5 to f05f73b Compare January 14, 2025 13:32
@palas palas marked this pull request as ready for review January 14, 2025 13:40
@palas palas requested a review from a team as a code owner January 14, 2025 13:40
@palas palas force-pushed the smelc/test-query-proposals branch 3 times, most recently from 9df1d61 to 1df035f Compare January 14, 2025 14:43
palas
palas approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@palas palas force-pushed the smelc/test-query-proposals branch from 1df035f to 90ab173 Compare January 14, 2025 14:52
@palas palas force-pushed the smelc/test-query-proposals branch from 90ab173 to dc2f8cb Compare January 14, 2025 14:54
@palas palas merged commit 1e0ab9a into utxo-hd-main Jan 14, 2025
102 of 114 checks passed
@palas palas deleted the smelc/test-query-proposals branch January 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palas palas palas approved these changes

Assignees

@palas palas

Labels
cardano-testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smelc @palas