Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update command to launch new constitution test #6044

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Update command to launch new constitution test #6044

merged 1 commit into from
Dec 2, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 29, 2024 •
edited
Loading

Description

Command to launch the propose and ratify new constitution was outdated. This PR updates it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

How to trust this PR

  1. It solely changes a comment
  2. Try the previous stanza: DISABLE_RETRIES=1 cabal test cardano-testnet-test --test-options '-p "/ProposeAndRatifyNewConstitution/"'
  3. Observe it runs 0 tests
  4. Try the new stanza: DISABLE_RETRIES=1 cabal test cardano-testnet-test --test-options '-p "/Propose And Ratify New Constitution/"'
  5. Observe the expected test is launched

@smelc smelc marked this pull request as ready for review November 29, 2024 16:26
@smelc smelc requested a review from a team as a code owner November 29, 2024 16:26
palas
palas approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out with

cardano-node/cardano-testnet/test/cardano-testnet-test/cardano-testnet-test.hs

Line 63 in ef5f0a9

, ignoreOnMacAndWindows "Propose And Ratify New Constitution" Gov.hprop_ledger_events_propose_new_constitution

@smelc smelc added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 2, 2024
@smelc smelc added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit f3978c3 Dec 2, 2024
23 checks passed
@smelc smelc deleted the smelc/fix-launching-test-stanza branch December 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@palas palas palas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smelc @palas @Jimbo4350