Integrate o-network changes for Genesis support / big ledger peer snapshots

[crocodile-dentist]

Description

This change introduces support for big ledger peers in the node. A new optional entry in network topology JSON parser is added that is intended to point to a path containing a serialized snapshot of big ledger peers taken from some slot a priori. When present, this file is decoded at node startup, or when a SIGHUP is triggered, and made available to the diffusion layer via reading from a TVar.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • roundtrip tests
  • integration tests
    See Runnings tests for more details
• Any changes are noted in the CHANGELOG.md for affected package
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

[carbolymer]

Why not camelcase?

[crocodile-dentist]

I though io_m_lps was a little clearer than ioMLps, or do you have something else in mind?

[carbolymer]

Having to prefix the variables with the types is usually a sign that you're working against the language. Here it is because you're trying to shoehorn your function into MaybeT which doesn't work here very well and forces you to work with variables with type IO (Maybe a) outside of MaybeT. Why not write this function like this:

updateLedgerPeerSnapshot :: Tracer IO (StartupTrace blk)
                         -> STM IO (Maybe PeerSnapshotFile)
                         -> (Maybe LedgerPeerSnapshot -> STM IO ())
                         -> IO (Maybe LedgerPeerSnapshot)
updateLedgerPeerSnapshot startupTracer readLedgerPeerPath writeVar = do
  mPeerSnapshotFile <- atomically readLedgerPeerPath
  mLedgerPeerSnapshot <- forM mPeerSnapshotFile $ \f -> do
    lps@(LedgerPeerSnapshot (wOrigin, _)) <- readPeerSnapshotFile f
    lps <$ traceWith startupTracer (LedgerPeerSnapshotLoaded wOrigin)
  atomically . writeVar $ mLedgerPeerSnapshot
  pure mLedgerPeerSnapshot

[crocodile-dentist]

Yes, that's most intuitive.

[crocodile-dentist]

Maybe I don't have to bump the protocol version at all in this patch based on review comment in related PR on consensus side

[github-actions]

This PR is stale because it has been open 45 days with no activity.