Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for node 8.7.0 #5533

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Release for node 8.7.0 #5533

merged 10 commits into from
Nov 22, 2023

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Nov 7, 2023 •
edited
Loading

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@jasagredo jasagredo mentioned this pull request Nov 7, 2023
Closed
53 tasks
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 4 times, most recently from 1f567e9 to 83f60b2 Compare November 15, 2023 16:16
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 2 times, most recently from a48bb35 to a4e6a44 Compare November 20, 2023 12:13
@jasagredo jasagredo changed the title WIP: Integration work for node 8.7.0 Integration work for node 8.7.0 Nov 20, 2023
@jasagredo jasagredo marked this pull request as ready for review November 20, 2023 12:43
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 0b239f4 to 6ddd276 Compare November 20, 2023 14:04
@jasagredo jasagredo changed the title Integration work for node 8.7.0 Release for node 8.7.0 Nov 20, 2023
jasagredo
jasagredo commented Nov 20, 2023
View reviewed changes
cardano-submit-api/CHANGELOG.md Show resolved Hide resolved
cardano-testnet/CHANGELOG.md Show resolved Hide resolved
trace-dispatcher/CHANGELOG.md Show resolved Hide resolved
trace-forward/CHANGELOG.md Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers/Diffusion.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Configuration/POM.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 2 times, most recently from 1fcfdca to 2842178 Compare November 20, 2023 14:58
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 3 times, most recently from fd66ba4 to d57e3ce Compare November 20, 2023 15:53
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from d57e3ce to ee02b91 Compare November 20, 2023 15:55
@carbolymer carbolymer mentioned this pull request Nov 20, 2023
Closed
9 tasks
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 3 times, most recently from 3aacb2c to 765d77b Compare November 21, 2023 09:21
@jasagredo jasagredo enabled auto-merge November 21, 2023 10:44
@jasagredo jasagredo disabled auto-merge November 21, 2023 12:05
@jasagredo jasagredo enabled auto-merge November 21, 2023 12:05
@carbolymer carbolymer disabled auto-merge November 21, 2023 12:09
@carbolymer carbolymer enabled auto-merge November 21, 2023 12:09
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 78dc0fd to dd7eae9 Compare November 21, 2023 13:01
@carbolymer carbolymer added this pull request to the merge queue Nov 21, 2023
@jasagredo jasagredo removed this pull request from the merge queue due to a manual request Nov 21, 2023
jasagredo and others added 5 commits November 21, 2023 17:50
@jasagredo
Integrate ouroboros-consensus
12ac9ec
@jasagredo
Update flakes
077cdb5
@jasagredo
Cleanup
4a1b0d4 
- Update cabal cache
- Cleanup yml files
- Update ci to Cabal 3.10.2.0
- Move `Changelog.md` to the appropiate section in cabal files
@jasagredo
Bump versions and changelogs
fa95540
@mgmeier @jasagredo
locli: avoid CI failure by not parsing empty input
8a79c6e
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from dd7eae9 to 8a79c6e Compare November 21, 2023 16:50
@disassembler disassembler added this pull request to the merge queue Nov 22, 2023
Merged via the queue into master with commit 34d89af Nov 22, 2023
20 of 22 checks passed
@disassembler disassembler deleted the jasagredo/node-8.7.0 branch November 22, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadales dnadales dnadales left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@coot coot coot approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@disassembler disassembler Awaiting requested review from disassembler

@lehins lehins Awaiting requested review from lehins

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasagredo @dnadales @carbolymer @coot @Jimbo4350 @disassembler @bolt12 @mgmeier