-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Annotator DecCBOR instances #4846
base: master
Are you sure you want to change the base?
Conversation
5bd2b7d
to
03a5f42
Compare
03a5f42
to
19adf8f
Compare
562fd85
to
3619c22
Compare
3619c22
to
edebbb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do no look at comments 😄
@@ -213,7 +213,7 @@ jobs: | |||
- set-algebra | |||
- small-steps | |||
- vector-map | |||
ghc: ["8.10.7", "9.2.8", "9.6.6", "9.8.4", "9.10.1"] | |||
ghc: ["9.2.8", "9.6.6", "9.8.4", "9.10.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't drop ghc-8.10.7 yet. See #4798
<! From | ||
<! From | ||
<! From | ||
<! D (maybeToStrictMaybe <$> decodeNullMaybe decCBOR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<! D (maybeToStrictMaybe <$> decodeNullMaybe decCBOR) | |
<! D (decodeNullStrictMaybe decCBOR) |
Annotated bodies bodiesBs <- decodeAnnotated decCBOR | ||
Annotated wits witsBs <- decodeAnnotated decCBOR | ||
Annotated auxDataMap auxDataBs <- decodeAnnotated decCBOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a better naming convention. IMHO Bytes is better than some BS 😄
Annotated bodies bodiesBs <- decodeAnnotated decCBOR | |
Annotated wits witsBs <- decodeAnnotated decCBOR | |
Annotated auxDataMap auxDataBs <- decodeAnnotated decCBOR | |
Annotated bodies bodiesBytes <- decodeAnnotated decCBOR | |
Annotated wits witsBytes <- decodeAnnotated decCBOR | |
Annotated auxDataMap auxDataBytes <- decodeAnnotated decCBOR |
Description
Write
DecCBOR
instances for types that haveDecCBOR Annotator
instances, by leveraging theMaybe ByteString
in versioned Decoder.Depends on era-less Memobytes PR: #4844
Closes: #4818
Checklist
CHANGELOG.md
files updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
updated (usescripts/gen-hie.sh
)