Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate DRep being a key or a script in certificate descriptions #1007

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 7, 2025

Changelog

- description: |
    Disambiguate DRep being a key or a script in certificate descriptions
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #756

How to trust this PR

Try the following before and after the PR:

# before
> cabal run cardano-cli -- conway governance drep registration-certificate   --drep-script-hash 8f33600845940d65bdbc7ea7a247a7997aa8558649128fa82c4c0468   --key-reg-deposit-amt "10000"   --out-file drep-multisig-reg.cert; cat drep-multisig-reg.cert | jq ".description"
"DRep Key Registration Certificate"
# after
> cabal run cardano-cli -- conway governance drep registration-certificate   --drep-script-hash 8f33600845940d65bdbc7ea7a247a7997aa8558649128fa82c4c0468   --key-reg-deposit-amt "10000"   --out-file drep-multisig-reg.cert; cat drep-multisig-reg.cert | jq ".description"
"DRep Script Registration Certificate"

and look at the diff of golden files

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Jan 7, 2025

cc @CarlosLopezDeLara, because I decided to go beyond #756 and change the labels for of retirement certificates and update certificates too, to be consistent.

@smelc smelc enabled auto-merge January 7, 2025 13:30
@smelc smelc force-pushed the smelc/correct-registration-certificate-description branch from a9c0616 to 63a77dc Compare January 8, 2025 09:48
@smelc smelc added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 75e6fc2 Jan 8, 2025
73 of 78 checks passed
@smelc smelc deleted the smelc/correct-registration-certificate-description branch January 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description field in SCRIPT based registration certificate says "DRep Key Registration Certificate"
2 participants