Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate cardano-ledger and plutus versions already on CHaP #711

Closed
wants to merge 13 commits into from
Closed

Integrate cardano-ledger and plutus versions already on CHaP #711

wants to merge 13 commits into from

Conversation

neilmayhew
Copy link
Contributor

Changelog

- description: |
    Integrate `cardano-ledger` and `plutus`
  type:
    - release

Context

Packages for cardano-ledger and plutus have already been released to CHaP.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@neilmayhew
Copy link
Contributor Author

This includes the changes from #619 which should be merged first. Both of these PRs contain temporary srp's that will be removed in the final integration PR after consensus and network have been released.

@neilmayhew neilmayhew marked this pull request as ready for review December 19, 2024 03:23
@carbolymer carbolymer force-pushed the neilmayhew/integrate-ledger branch from 245d5c9 to 514417e Compare December 30, 2024 10:21
carbolymer
carbolymer reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased onto latest master.
LGTM so far. The commit from SRP is gone though.

scripts/ci/check-cabal-files.sh Show resolved Hide resolved
@neilmayhew
Copy link
Contributor Author

This has been subsumed by #687 because it doesn't build on its own

@neilmayhew neilmayhew closed this Jan 8, 2025
@neilmayhew neilmayhew deleted the neilmayhew/integrate-ledger branch January 8, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer left review comments

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilmayhew @carbolymer @coot