Draft the new, definite textEnvelopeType for Tx #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All transactions are now serialized and deserialized as 'Witnessed' transactions using the Ledger binary format.
Changelog
Context
Draft for the transaction envelope type that a cardano-api transaction should have going forward. Before, only
serialiseTxLedgerCddl
would produce the correctly parseableWitnessed Tx ConwayEra
for example. However, that function is deprecated and we should fix theserialiseToTextEnvelope
invocation forTx era
directly.How to trust this PR
There are probably several things missing and this is just a draft for how I, as a user, would want the cardano-api/-cli to operate (using a single
Witnessed Tx <era>
type).Checklist