[SRE-2199] Package latest version of Redis Roaring into a Docker image #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itskingori
force-pushed
the
package_redis_roaring
branch
from
edfc54a
to
cd01171
Compare
itskingori
commented
Feb 17, 2022
| @@ -0,0 +1 @@ | |||
| FROM aviggiano/redis-roaring@sha256:0c4e97accbf6821b828b46aef0b77572b6d3866b6fb3b17e9f0ffd527f8cbeb3 | |||
There was a problem hiding this comment.
Tested locally ...
$ docker build -t zappi/redis-roaring .
[+] Building 2.8s (6/6) FINISHED
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 143B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 34B 0.0s
=> [internal] load metadata for docker.io/aviggiano/redis-roaring@sha256:0c4e97accbf6821b828b46aef0b77572b6d3866b6fb3b17e9f0ffd527f8cbeb3 2.6s
=> [auth] aviggiano/redis-roaring:pull token for registry-1.docker.io 0.0s
=> CACHED [1/1] FROM docker.io/aviggiano/redis-roaring@sha256:0c4e97accbf6821b828b46aef0b77572b6d3866b6fb3b17e9f0ffd527f8cbeb3 0.0s
=> exporting to image 0.0s
=> => exporting layers 0.0s
=> => writing image sha256:a569709eb2d9d4e7d241c63299cbf74de28632d0bd031093cea9c21f95bbf375 0.0s
=> => naming to docker.io/zappi/redis-roaring
README.md
Outdated
Comment on lines
0
to
1
| # docker-redis-roaring No newline at end of file | ||
| # Redis Roaring |
There was a problem hiding this comment.
Copied from upstream README.md with minimal changes i.e. whitespace, extra lines, markdown heading format.
itskingori
force-pushed
the
package_redis_roaring
branch
from
82b2f74
to
2e02e69
Compare
itskingori
changed the title
itskingori
force-pushed
the
package_redis_roaring
branch
from
2e02e69
to
9073ae9
Compare
hadrianvalentine
approved these changes
Feb 17, 2022
|
|
itskingori
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a lazy solution to locking down versions to avoid implicit upgrades. Ideally we would have preferred to build our own from scratch but I've had concerns around that process. See:
I choseChanged in 3da62ab.<datestamp>-<shortsha>because the first part at least makes sure we order by recency and the second part communicates what version of upstream we're using. I chose not to take semantic versioning because I wasn't sure which version I should use (i.e. Redis or CRoaring) ... and especially since the upstream project (i.e. Redis Roaring) doesn't have any versioning.See: https://hub.docker.com/repository/docker/zappi/redis-roaring.