Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline for view semantics #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix pipeline for view semantics #14

wants to merge 2 commits into from

Conversation

tkarna
Copy link
Collaborator

@tkarna tkarna commented Aug 12, 2024

  • adds cse,canonicalize passes before one-shot-bufferize to remove duplicate bufferization.to_memref ops
    • if multiple identical bufferization.to_memref ops are present, one-shot-bufferize will create a copies
  • adds a test that verifies that view semantics are correctly preserved

@tkarna tkarna requested a review from fschlimb August 12, 2024 14:20
fschlimb
fschlimb approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
How/why can duplicate to_memrefs happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschlimb fschlimb fschlimb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkarna @fschlimb