Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path issues and File not closed error #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BarisSari
Copy link

@BarisSari BarisSari commented Jan 4, 2021

Hello. First of all, thanks for this repository! I'm thinking to use this repository for my side project. However, in my first experiments, I faced a few problems and I thought it might be better to open this PR instead of workaround in my fork.

This PR solves the following issues:

  • BASE_DIR was pointing to project_root/util directory. I changed it to the project root.
  • When python -m crawl_profile user1 user2 and python -m extract_images are run, the second command is failing (No such file or directory error) because it tries to find profiles in /profiles directory. I corrected paths.
  • os module is throwing errors when the given directory is not found or given directory is empty. I added checks and logs for them.
  • json file wasn't closed. I added with clause to open() instead of a new f.close() line.

Note: I'm not a Raspberry Pi user. So, I didn't test these changes on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant