Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setters threading #712

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Setters threading #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f54af
MAINT: Remove unused method
bnmajor Dec 15, 2023
2908b96
BUG: Run setters in a background thread
bnmajor Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions itkwidgets/cell_watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ def setup(self):
self.shell = get_ipython()
self.kernel = self.shell.kernel
self.shell_stream = getattr(self.kernel, "shell_stream", None)
self.execute_request_handler = self.kernel.shell_handlers["execute_request"]
# Keep a reference to the ipykernel execute_request function
self.execute_request_handler = self.kernel.shell_handlers["execute_request"]
self.current_request = None
self.waiting_on_viewer = False
self.results = {}
Expand Down Expand Up @@ -204,24 +204,7 @@ def _callback(self, *args, **kwargs):
self.update_namespace()
self.create_task(self.execute_next_request)

def find_view_object_names(self):
from .viewer import Viewer
# Used to determine that all references to Viewer
# objects are ready before a cell is run
objs = self.viewers.viewer_objects
user_vars = [k for k in self.shell.user_ns.keys() if not k.startswith('_')]
for var in user_vars:
# Identify which variable the view object has been assigned to
value = self.shell.user_ns[var]
if isinstance(value, Viewer) and value.__str__() in objs:
idx = objs.index(value.__str__())
self.viewers.set_name(objs[idx], var)

def post_run_cell(self, response):
# If a cell has been run and there are viewers with no variable
# associated with them check the user namespace to see if they have
# been added
# Abort remaining cells on error in execution
if response.error_in_exec is not None:
self.abort_all = True
if self.viewers.not_named:
self.find_view_object_names()
Loading