-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add builds for ITK-5.4.2 #105
Conversation
Add macos-15 build and ITK5.4.2 tags.
We should test this in at least one remote module. Maybe we should keep a branch named |
I now see that 5.4.2 wheels are not up yet. Maybe we should revert this until then? |
@dzenanz I don't know how to make the wheels. I won't be able to work on this for a while. revert if you want. |
Here are the instructions for wheel generation: |
That task is tracked here: InsightSoftwareConsortium/ITK#5144. Matt, do you plan to do that? |
I tested this in Montage module, and I realized that for C++ testing, it does not matter that Python wheels do not exist. So there is no urgent need to revert this. Some problems are possible due to ITK version discrepancy between C++ (5.4.2) and Python (5.4.0). |
Yes, I plan to start Python package builds for 5.4.2 this week. But Python packages are not needed for this change. However, adding |
Removing code is easier than adding. I noticed that the new build type has a very long name ( |
Implemented in PR #107. |
Add macos-15 build and ITK5.4.2 tags.