Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add builds for ITK-5.4.2 #105

Merged
merged 1 commit into from
Jan 27, 2025
Merged

ENH: Add builds for ITK-5.4.2 #105

merged 1 commit into from
Jan 27, 2025

Conversation

hjmjohnson
Copy link
Member

Add macos-15 build and ITK5.4.2 tags.

Add macos-15 build and ITK5.4.2 tags.
@hjmjohnson hjmjohnson self-assigned this Jan 27, 2025
@dzenanz dzenanz requested a review from thewtex January 27, 2025 21:27
@hjmjohnson hjmjohnson merged commit 8040681 into main Jan 27, 2025
1 check passed
@dzenanz dzenanz deleted the branch-v5.4.2 branch January 27, 2025 21:34
@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

We should test this in at least one remote module. Maybe we should keep a branch named v5.4.2, to keep the same pattern with v5.4.0.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

I now see that 5.4.2 wheels are not up yet. Maybe we should revert this until then?

@dzenanz dzenanz mentioned this pull request Jan 27, 2025
@hjmjohnson
Copy link
Member Author

@dzenanz I don't know how to make the wheels. I won't be able to work on this for a while. revert if you want.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

That task is tracked here: InsightSoftwareConsortium/ITK#5144. Matt, do you plan to do that?

@dzenanz
Copy link
Member

dzenanz commented Jan 28, 2025

I tested this in Montage module, and I realized that for C++ testing, it does not matter that Python wheels do not exist. So there is no urgent need to revert this. Some problems are possible due to ITK version discrepancy between C++ (5.4.2) and Python (5.4.0).

@thewtex
Copy link
Member

thewtex commented Jan 28, 2025

That task is tracked here: InsightSoftwareConsortium/ITK#5144. Matt, do you plan to do that?

Yes, I plan to start Python package builds for 5.4.2 this week.

But Python packages are not needed for this change.

However, adding macos-15 for the C++ builds makes C++ macos-14 unnecessary.

@dzenanz
Copy link
Member

dzenanz commented Jan 28, 2025

C++ macos-14 unnecessary

Removing code is easier than adding.

I noticed that the new build type has a very long name (build-test-cxx (macos-15, clang, clang++, MinSizeRel)), as seen here. The other builds have shorter names, e.g. build-test-cxx (macos-14).

@dzenanz
Copy link
Member

dzenanz commented Jan 29, 2025

Implemented in PR #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants