Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Update KWStyle #5132

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 13, 2025

Attempting the address build warnings on Clang. Example:

KWStyle/Utilities/boost/xpressive/basic_regex.hpp:200:43: note: in instantiation of member function 'boost::xpressive::regex_compiler<std::__wrap_iter<const char *>>::compile' requested here
  200 |         return regex_compiler<BidiIter>().compile(begin, flags);
      |                                           ^

KWStyle/kwsParser.cxx:575:32: note: in instantiation of member function 'boost::xpressive::basic_regex<std::__wrap_iter<const char *>>::compile' requested here

  575 |   sregex unixNewline = sregex::compile("\r?\n|\r");
      |                                ^
In file included from KWStyle/kwsParser.cxx:18:
In file included from KWStyle/Utilities/boost/xpressive/xpressive.hpp:18:
In file included from KWStyle/Utilities/boost/xpressive/xpressive_static.hpp:24:
In file included from KWStyle/Utilities/boost/xpressive/regex_primitives.hpp:22:
In file included from KWStyle/Utilities/boost/xpressive/detail/core/matchers.hpp:46:
KWStyle/Utilities/boost/xpressive/detail/core/matcher/simple_repeat_matcher.hpp:219:32: warning: definition of implicit copy constructor for 'simple_repeat_matcher<boost::xpressive::detail::shared_matchable<std::__wrap_iter<const char *>>, mpl_::bool_<true>>' is deprecated because it has a user-provided copy assignment operator [-Wdeprecated-copy-with-user-provided-copy]
  219 |         simple_repeat_matcher &operator =(simple_repeat_matcher const &);
      |                                ^

PR Checklist

Attempting the address build warnings on Clang. Example:

KWStyle/Utilities/boost/xpressive/basic_regex.hpp:200:43: note: in instantiation of member function 'boost::xpressive::regex_compiler<std::__wrap_iter<const char *>>::compile' requested here
  200 |         return regex_compiler<BidiIter>().compile(begin, flags);
      |                                           ^

KWStyle/kwsParser.cxx:575:32: note: in instantiation of member function 'boost::xpressive::basic_regex<std::__wrap_iter<const char *>>::compile' requested here

  575 |   sregex unixNewline = sregex::compile("\r?\n|\r");
      |                                ^
In file included from KWStyle/kwsParser.cxx:18:
In file included from KWStyle/Utilities/boost/xpressive/xpressive.hpp:18:
In file included from KWStyle/Utilities/boost/xpressive/xpressive_static.hpp:24:
In file included from KWStyle/Utilities/boost/xpressive/regex_primitives.hpp:22:
In file included from KWStyle/Utilities/boost/xpressive/detail/core/matchers.hpp:46:
KWStyle/Utilities/boost/xpressive/detail/core/matcher/simple_repeat_matcher.hpp:219:32: warning: definition of implicit copy constructor for 'simple_repeat_matcher<boost::xpressive::detail::shared_matchable<std::__wrap_iter<const char *>>, mpl_::bool_<true>>' is deprecated because it has a user-provided copy assignment operator [-Wdeprecated-copy-with-user-provided-copy]
  219 |         simple_repeat_matcher &operator =(simple_repeat_matcher const &);
      |                                ^
@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jan 13, 2025
@dzenanz dzenanz marked this pull request as ready for review January 14, 2025 15:11
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

@dzenanz dzenanz merged commit 91f4091 into InsightSoftwareConsortium:master Jan 14, 2025
15 checks passed
@dzenanz dzenanz deleted the updateKWStyle branch January 14, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants