Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Change variable name to meet ITK style. #4702

Merged
merged 1 commit into from
Jun 1, 2024
Merged

STYLE: Change variable name to meet ITK style. #4702

merged 1 commit into from
Jun 1, 2024

Conversation

hjmjohnson
Copy link
Member

Simple variable name change for style.

PR Checklist

@hjmjohnson hjmjohnson added the type:Style Style changes: no logic impact (indentation, comments, naming) label May 31, 2024
@hjmjohnson hjmjohnson requested a review from jhlegarreta May 31, 2024 17:45
@hjmjohnson hjmjohnson self-assigned this May 31, 2024
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Video Issues affecting the Video module labels May 31, 2024
@dzenanz
Copy link
Member

dzenanz commented May 31, 2024

@thewtex Did Apply clang-format to PR action break again?

@hjmjohnson
Copy link
Member Author

FYI: I have no clang-format failures locally.

./clang-format-Darwin -i ../Modules/Video/Core/test/itkTemporalProcessObjectTest.cxx

@hjmjohnson hjmjohnson force-pushed the style-variable-name branch from a7d31ec to 3d4f6ec Compare May 31, 2024 18:04
@thewtex
Copy link
Member

thewtex commented May 31, 2024

@thewtex Did Apply clang-format to PR action break again?

It does not work on fork PRs.

@hjmjohnson hjmjohnson merged commit e35e66e into InsightSoftwareConsortium:master Jun 1, 2024
14 checks passed
@hjmjohnson hjmjohnson deleted the style-variable-name branch June 1, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@seanm seanm seanm approved these changes

@thewtex thewtex thewtex approved these changes

@jhlegarreta jhlegarreta Awaiting requested review from jhlegarreta

Assignees

@hjmjohnson hjmjohnson

Labels
area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hjmjohnson @dzenanz @thewtex @seanm