Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Transfer the wiki FAQ page to Markdown documentation #4308

Merged

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Nov 9, 2023

Transfer the wiki FAQ page to Markdown documentation: https://itk.org/Wiki/ITK/FAQ

Add the corresponding entry in the Learn section of the documentation index.

Take advantage of the transition to:

  • Update URLs, including changing http to https, fixing broken URLs,
    etc.
  • Link ITK and VTK classes to their Doxygen documentation pages.
  • Highlight parts (e.g. class names) using Markdown syntax.
  • Refactor the data format section to: include mesh and point set, and
    transform file format sections, mention other file formats potentially
    supported by remote modules. Add links to the file format reference
    pages, and the Doxygen documentation of the ITK IO classes involved.
  • Make the BibTeX list style consistent, remove broken URLs pointing to
    old versions of the SW Guide or all pointing to the latest PDF
    available online, etc.
  • Make the BibTeX list style consistent, remove broken URLs pointing to
    old versions of the SW Guide or all pointing to the latest PDF
    available online, etc.
  • Remove outdated paragraph about libraries to build visualization
    applications.
  • Change mentions to ImageViewer to itkwidgets.
  • Prefer pointing to the Python imageio package over ImageMagick.
  • Mention itk-wasm dicom to read a volume from a DICOM series.
  • Reword the language binding section: remove Java and mention that
    further bindings are available through SimpleITK and itk-wasm.
  • Remove the What does \Error opening hint file NOTFOUND` mean?`
    section.
  • Remove the language binding/wrapping section, as it is outdated: it
    refers to the current SWIG wrapping before it was integrated into the
    ITK repository.
  • Remove mentions to section number and pages in the ITK SW Guide, as
    they have changed and may change in the future.
  • Remove the emacs coding style section.
  • Rewrite the Vim coding style section, as ITK's coding style is now
    enforced and/or checked automatically, and as ITK switched from
    txx to hxx suffices some time ago.
  • Remove the empty What is the `ITK_TEMPLATE_VISIBILITY_DEFAULT`
    CMake option?` section.
  • Remove the outdated Platform-specific questionssection.
  • Fix typos and grammar, and reword passages for better understanding.
  • Change the title to Frequently asked questions.

PR Checklist

@github-actions github-actions bot added type:Documentation Documentation improvement or change area:Documentation Issues affecting the Documentation module labels Nov 9, 2023
in case of desperation.

1. Use the [`itk::ImageSeriesReader`](https://itk.org/Doxygen/html/classitk_1_1ImageSeriesReader.html) in combination with the
`DicomSeriesFileNames`. For a full example on how to do this,
Copy link
Member Author

@jhlegarreta jhlegarreta Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DicomSeriesFileNames does not exist as a class name.

(with the motto: "MIND is not DICOM"). This application loads
DICOM files over the network and export them in MetaImage format.
This application is open source and it is available at:
http://www.jeffro.net/mind/ and http://caddlab.rad.unc.edu/software/MIND/.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are broken. Is this relevant? @aylward ?

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Nov 9, 2023

Sorry for being active only now; could not devote time to it during the day.

A few general notes:

which one should be used?

  • We would need to pass a Markdown linter to all these files
  • Did not change line length after automatic conversion (72 vs 79).

A few in-line notes.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved

### Is ITK tested?

Please see this page: [ITK/Testing](https://itk.org/Wiki/ITK/Testing).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs refresh


Please see the [third party applications](https://itk.org/Wiki/ITK/Third_Party_Applications) page for
visualization applications that used ITK to perform image
reading/writing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a third-party applications page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewtex
Copy link
Member

thewtex commented Nov 9, 2023

Links to other wiki pages that need to be transitioned:

I added to this issue: #4063

Those could also be added there so we have one place to keep track of them.

@thewtex
Copy link
Member

thewtex commented Nov 9, 2023

wiki page deprecations

We could also consider placing a banner on the landing page.

@jhlegarreta jhlegarreta force-pushed the ImportFAQFromWiki branch 2 times, most recently from 894e5e6 to 2a39901 Compare November 10, 2023 01:09
@jhlegarreta
Copy link
Member Author

@thewtex Addressed the comments. Others may be willing to chime in to answer the pending questions.

About the links to the Wiki pages that have not been transitioned, I do not think it is feasible to wait until all is transitioned to merge the contributions, as this is a large endeavor.

@thewtex
Copy link
Member

thewtex commented Nov 10, 2023

@thewtex Addressed the comments. Others may be willing to chime in to answer the pending questions.

@jhlegarreta awesome!

About the links to the Wiki pages that have not been transitioned, I do not think it is feasible to wait until all is transitioned to merge the contributions, as this is a large endeavor.

I agree. If there is outdated content or wiki content, we should omit it for now, though, in my opinion.

@jhlegarreta jhlegarreta force-pushed the ImportFAQFromWiki branch 2 times, most recently from 0ecad0f to b482b87 Compare November 11, 2023 01:59
@jhlegarreta jhlegarreta force-pushed the ImportFAQFromWiki branch 2 times, most recently from b482b87 to 9a44d3a Compare November 11, 2023 02:29
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
application that allows you to load DICOM series and export them in
MetaImage and Analyze format (among others). She graciously has made
this application publicly available at:
https://darkwing.uoregon.edu/~jolinda/MRIConvert/.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should replace with dcm2niix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dcm2niix is great to convert to NIfTI, but not sure it is able to export to MetaImage, and to Analyze. Not about other tools.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛑️

Documentation/docs/index.md Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
Documentation/docs/learn/faq.md Show resolved Hide resolved
Documentation/docs/learn/faq.md Outdated Show resolved Hide resolved
@jhlegarreta
Copy link
Member Author

jhlegarreta commented Nov 13, 2023

Still seems to be present in the latest build previews.

Not sure about the direction of the comment. Should the section be removed? Maybe reworked to tell people how to build applications with ITK + VTK?

This paragraph can be removed.

Removed in 66fdb26.

Transfer the wiki FAQ page to Markdown documentation:
https://itk.org/Wiki/ITK/FAQ

Add the corresponding entry in the `Learn` section of the documentation
index, and set the `maxdepth` to 1 to avoid showing the FAQ page
sections.

Take advantage of the transition to:
- Update URLs, including changing `http` to `https`, fixing broken URLs,
  etc.
- Link ITK and VTK classes to their Doxygen documentation pages.
- Highlight parts (e.g. class names) using Markdown syntax.
- Refactor the data format section to: include mesh and point set, and
  transform file format sections, mention other file formats potentially
  supported by remote modules. Add links to the file format reference
  pages, and the Doxygen documentation of the ITK IO classes involved.
- Make the BibTeX list style consistent, remove broken URLs pointing to
  old versions of the SW Guide or all pointing to the latest PDF
  available online, etc.
- Remove outdated paragraph about libraries to build visualization
  applications.
- Change mentions to `ImageViewer` to `itkwidgets`.
- Prefer pointing to the Python `imageio` package over `ImageMagick`.
- Mention `itk-wasm dicom` to read a volume from a DICOM series.
- Reword the language binding section: remove Java and mention that
  further bindings are available through SimpleITK and itk-wasm.
- Remove the `What does \`Error opening hint file NOTFOUND\` mean?`
  section.
- Remove the language binding/wrapping section, as it is outdated: it
  refers to the current SWIG wrapping before it was integrated into the
  ITK repository.
- Remove mentions to section number and pages in the ITK SW Guide, as
  they have changed and may change in the future.
- Remove the emacs coding style section, and the outdated paragraph
  about the CMake indentantion and syntax Vim file.
- Rewrite the Vim coding style section, as ITK's coding style is now
  enforced and/or checked automatically, and as ITK switched from
  `txx` to `hxx` suffices some time ago.
- Remove the empty `What is the `\`ITK_TEMPLATE_VISIBILITY_DEFAULT\`
  CMake option?` section.
- Remove the outdated `Platform-specific questions`section.
- Fix typos and grammar, and reword passages for better understanding.
- Change the title to `Frequently asked questions`.
@thewtex
Copy link
Member

thewtex commented Nov 17, 2023

Still seems to be present in the latest build previews.

Not sure about the direction of the comment. Should the section be removed? Maybe reworked to tell people how to build applications with ITK + VTK?

Sorry for the lack of clarity. I think I was referencing an additional paragraph that was out-of-date that is gone.

In the future, we could link to the itk-vtk python interface #4320, but there is a lot of great content here. I think we should get it in and start building on it.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jhlegarreta !

@hjmjohnson hjmjohnson merged commit 7ced4cc into InsightSoftwareConsortium:master Nov 30, 2023
6 checks passed
@jhlegarreta jhlegarreta deleted the ImportFAQFromWiki branch November 30, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Documentation Issues affecting the Documentation module type:Documentation Documentation improvement or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants