STYLE: ResetNextSeed GTest should not use instance for GetNextSeed call #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Testing
dzenanz
approved these changes
Nov 6, 2023
jhlegarreta
reviewed
Nov 6, 2023
Modules/Core/Common/test/itkMersenneTwisterRandomVariateGeneratorGTest.cxx
Outdated
Show resolved
Hide resolved
N-Dekker
force-pushed
the
Remove-instance-from-ResetNextSeed-GTest
branch
from
838e9be to
d871a24
Compare
`MersenneTwisterRandomVariateGenerator::GetNextSeed()` is a static member function, so there is no need to call it via an instance of the generator, in the `MersenneTwisterRandomVariateGenerator.ResetNextSeed` unit test. The commit also adds documentation to the unit test. Suggested by clang-tidy: https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html
N-Dekker
force-pushed
the
Remove-instance-from-ResetNextSeed-GTest
branch
from
d871a24 to
c4b8e20
Compare
dzenanz
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MersenneTwisterRandomVariateGenerator::GetNextSeed()is a static member function, so there is no need to call it via an instance of the generator, in theMersenneTwisterRandomVariateGenerator.ResetNextSeedunit test.The commit also adds some documentation to the unit test.
Suggested by clang-tidy:
https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html
Obviously it was my own fault 😸 introduced with:
MersenneTwisterRandomVariateGenerator::ResetNextSeed()#4247