Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Increase optimizer classes coverage #4287

Merged
merged 2 commits into from
Nov 8, 2023
Merged

ENH: Increase optimizer classes coverage #4287

merged 2 commits into from
Nov 8, 2023

Conversation

jhlegarreta
Copy link
Member

  • ENH: Increase itk::SingleValuedNonLinearVnlOptimizer coverage
  • ENH: Increase coverage for itk::ObjectToObjectOptimizerBaseTemplate

PR Checklist

@jhlegarreta
ENH: Increase itk::SingleValuedNonLinearVnlOptimizer coverage
7d55e08 
Increase `itk::SingleValuedNonLinearVnlOptimizer` coverage: test the
`CanUseScales` method.
@jhlegarreta
ENH: Increase coverage for itk::ObjectToObjectOptimizerBaseTemplate
a4120d8 
Increase coverage for `itk::ObjectToObjectOptimizerBaseTemplate`: test
the `CanUseScales` method and the Set/Get/Boolean macros for the
`DoEstimateScales` ivar.

Take advantage of the commit to remove an uninformative comment.
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct type:Coverage Code coverage impacts area:Numerics Issues affecting the Numerics module labels Nov 5, 2023
thewtex
thewtex approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dzenanz dzenanz merged commit 3324ef0 into InsightSoftwareConsortium:master Nov 8, 2023
6 checks passed
@jhlegarreta jhlegarreta deleted the IncreaseOptimizerClassesCov branch November 8, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:Numerics Issues affecting the Numerics module type:Coverage Code coverage impacts type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhlegarreta @thewtex @hjmjohnson @dzenanz