Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Increase itk::DiscreteGaussianCurvatureQuadEdgeMeshFilter coverage #4285

Merged
merged 2 commits into from
Nov 9, 2023
Merged

ENH: Increase itk::DiscreteGaussianCurvatureQuadEdgeMeshFilter coverage #4285

merged 2 commits into from
Nov 9, 2023

Conversation

jhlegarreta
Copy link
Member

  • STYLE: Use medial capitals to name variables in test
  • ENH: Increase itk::DiscreteGaussianCurvatureQuadEdgeMeshFilter coverage

PR Checklist

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Filtering Issues affecting the Filtering module type:Coverage Code coverage impacts labels Nov 5, 2023
@jhlegarreta
Copy link
Member Author

/azp run ITK.Linux

thewtex
thewtex approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dzenanz
Copy link
Member

dzenanz commented Nov 8, 2023

Please rebase.

@jhlegarreta
STYLE: Use medial capitals to name variables in test
2cc791c 
Use medial capitals to name variables in Cxx test, and so adhere to the
ITK SWG guidelines.
@jhlegarreta
ENH: Increase itk::DiscreteGaussianCurvatureQuadEdgeMeshFilter coverage
1972628 
Increase coverage for
`itk::DiscreteGaussianCurvatureQuadEdgeMeshFilter`: exercise basic
object methods using the `ITK_EXERCISE_BASIC_OBJECT_METHODS` macro,
and remove the inconsequential call to print the filter at the end of
the test: rely on the basic method exercising macro call.
@jhlegarreta jhlegarreta force-pushed the IncreaseDiscrGaussCurvatureQuadEdgeMeshFilterCov branch from 2880a1d to 1972628 Compare November 8, 2023 23:24
@thewtex thewtex merged commit ab251dc into InsightSoftwareConsortium:master Nov 9, 2023
6 checks passed
@jhlegarreta jhlegarreta deleted the IncreaseDiscrGaussCurvatureQuadEdgeMeshFilterCov branch November 9, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:Filtering Issues affecting the Filtering module type:Coverage Code coverage impacts type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @dzenanz @thewtex