Skip to content

Commit

Permalink
WIP: add test to reproduce SimpleITK issue #2220
Browse files Browse the repository at this point in the history
Incorrect results are being computed on windows with the Compose
filter ( and maybe other filters) and VectorImages of sizes >4GB.
  • Loading branch information
blowekamp committed Dec 14, 2024
1 parent 526fe30 commit eaa3785
Show file tree
Hide file tree
Showing 2 changed files with 105 additions and 0 deletions.
1 change: 1 addition & 0 deletions Modules/Filtering/ImageGrid/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ itk_add_test(

set(ITKImageGridGTests
itkChangeInformationImageFilterGTest.cxx
itkComposeImageFilterGTest.cxx
itkResampleImageFilterGTest.cxx
itkSliceImageFilterTest.cxx
itkTileImageFilterGTest.cxx
Expand Down
104 changes: 104 additions & 0 deletions Modules/Filtering/ImageGrid/test/itkComposeImageFilterGTest.cxx
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
/*=========================================================================
*
* Copyright NumFOCUS
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0.txt
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*=========================================================================*/

// The header file to be tested:
#include "itkComposeImageFilter.h"
#include "itkVectorIndexSelectionCastImageFilter.h"
#include "itkMinimumMaximumImageCalculator.h"
#include "itkExtractImageFilter.h"
#include "itkPasteImageFilter.h"


#include "itkImage.h"

// Google Test header file:
#include <gtest/gtest.h>

// Standard C++ header files:
#include <limits>
#include <random>


TEST(ComposeImageFilter, simpleitk_2220)
{
// Test case for SimpleITK issue #2220
// Reported data corruption with 4G compose on Windows system


const unsigned int size = 400;
const unsigned int nchannels = 100;
using ImageType = itk::Image<unsigned char, 3>;
using VectorImageType = itk::VectorImage<unsigned char, 3>;
std::vector<ImageType::Pointer> images;

for (unsigned int i = 0; i < nchannels; ++i)
{
auto image = ImageType::New();
ImageType::RegionType region;
ImageType::SizeType imageSize = { { size, size, size } };
region.SetSize(imageSize);
image->SetRegions(region);
image->Allocate();
image->FillBuffer(i % 250);

images.push_back(image);
}

using ComposeFilterType = itk::ComposeImageFilter<ImageType>;
ComposeFilterType::Pointer composeFilter = ComposeFilterType::New();
for (unsigned int i = 0; i < nchannels; ++i)
{
composeFilter->SetInput(i, images[i]);
}

composeFilter->Update();
VectorImageType::Pointer img = composeFilter->GetOutput();
std::cout << "Compose filter executed." << std::endl;

for (unsigned int i = 0; i < nchannels; ++i)
{
itk::IndexValueType z = i;
std::map<unsigned int, unsigned int> values;

for (itk::IndexValueType y = 0; y < size; ++y)
{
for (itk::IndexValueType x = 0; x < size; ++x)
{
itk::Index<3> idx = { { x, y, z } };

auto pixel = img->GetPixel(idx);
if (pixel[i] != i % 250)
{
++values[pixel[i]];
}
}
}

EXPECT_TRUE(values.empty()) << "channel " << i << " has incorrect values;" << std::endl;

if (!values.empty())
{
std::cout << "values: ";
for (auto v : values)
{
std::cout << v.first << "(" << v.second << "), ";
}
std::cout << std::endl;
}
}
}

0 comments on commit eaa3785

Please sign in to comment.