WIP: Preserve compatible behavior don't change default yet.

InsightSoftwareConsortium · Dec 18, 2024 · 6bf2ffe · 6bf2ffe
1 parent 9029980
commit 6bf2ffe
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 16 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -372,10 +372,6 @@ mark_as_advanced(ITK_NIFTI_IO_ANALYZE_FLAVOR)
 option(ITK_NIFTI_IO_SFORM_PERMISSIVE_DEFAULT "Allow non-orthogonal rotation matrix in NIFTI sform by default" OFF)
 mark_as_advanced(ITK_NIFTI_IO_SFORM_PERMISSIVE_DEFAULT)
 
-# Automatically convert MINC coordinate system from PositiveCoordinateOrientation RAS to PositiveCoordinateOrientation LPS
-option(ITK_MINC_IO_RAS_TO_LPS "Convert MINC coordinate system from PositiveCoordinateOrientation RAS to PositiveCoordinateOrientation LPS by default" ON)
-
-mark_as_advanced(ITK_MINC_IO_RAS_TO_LPS)
 #-----------------------------------------------------------------------------
 # ITK build classes that are in the review process
 # ITK_USE_REVIEW is deprecated, only kept for backward compatibility

diff --git a/Modules/IO/MINC/src/CMakeLists.txt b/Modules/IO/MINC/src/CMakeLists.txt
@@ -1,5 +1,3 @@
-configure_file(itkMINCImageIOConfigurePrivate.h.in itkMINCImageIOConfigurePrivate.h @ONLY)
-include_directories("${CMAKE_CURRENT_BINARY_DIR}")
 
 set(ITKIOMINC_SRC itkMINCImageIO.cxx itkMINCImageIOFactory.cxx)
 

diff --git a/Modules/IO/MINC/src/itkMINCImageIO.cxx b/Modules/IO/MINC/src/itkMINCImageIO.cxx
@@ -29,8 +29,6 @@
 
 #include <memory> // For unique_ptr.
 
-#include "itkMINCImageIOConfigurePrivate.h"
-
 
 extern "C"
 {
@@ -238,7 +236,7 @@ MINCImageIO::CloseVolume()
 
 MINCImageIO::MINCImageIO()
   : m_MINCPImpl(std::make_unique<MINCImageIOPImpl>())
-  , m_RAStoLPS(ITK_MINC_IO_RAS_TO_LPS)
+  , m_RAStoLPS(false)
 {
   for (auto & dimensionIndex : m_MINCPImpl->m_DimensionIndices)
   {

diff --git a/Modules/IO/MINC/test/itkMINCImageIOTest4.cxx b/Modules/IO/MINC/test/itkMINCImageIOTest4.cxx
@@ -28,9 +28,6 @@
 #include "itkImageMomentsCalculator.h"
 #include "itkStdStreamStateSave.h"
 #include "itkTestingMacros.h"
-
-#include "itkMINCImageIOConfigurePrivate.h"
-
 template <typename ImageType>
 int
 test_image_moments(const char * input_image,
@@ -133,7 +130,7 @@ itkMINCImageIOTest4(int argc, char * argv[])
   const char * input = argv[1];
   const char * output = argv[2];
   int          ras_to_lps_test = atoi(argv[3]);
-  bool         ras_to_lps = ras_to_lps_test < 0 ? ITK_MINC_IO_RAS_TO_LPS : ras_to_lps_test == 1;
+  bool         ras_to_lps = ras_to_lps_test < 0 ? false : ras_to_lps_test == 1;
 
   double total = 0.0;
   double mx = 0.0;

diff --git a/Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx b/Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx
@@ -34,16 +34,14 @@
 #include "itkImageRegionIterator.h"
 #include "vnl/vnl_vector_fixed.h"
 
-#include "itkMINCImageIOConfigurePrivate.h"
-
 
 namespace itk
 {
 
 template <typename TParametersValueType>
 MINCTransformIOTemplate<TParametersValueType>::MINCTransformIOTemplate()
   : m_XFM_initialized(false)
-  , m_RAStoLPS(ITK_MINC_IO_RAS_TO_LPS)
+  , m_RAStoLPS(false)
 {}
 
 template <typename TParametersValueType>