iprules.sh into netcontrol #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awing-ding
added
enhancement
|
It would be better if iprules methods were in their own separate class (and file), as they don't really have anything to do with nftables |
pixup1
reviewed
Oct 20, 2024
netcontrol/nft.py
Outdated
| vpn (str): VPN routing table name | ||
| """ | ||
| try: | ||
| self._execute_nft_cmd(f"add rule insalan netcontrol-forward fwmark {mark} lookup {vpn}") |
There was a problem hiding this comment.
iprules aren't managed byt nft but by ip rule (cf iprules.sh)
There was a problem hiding this comment.
ohh okay, i clearly misunderstood the assignment 😂
|
maybe the file should be elsewhere ? |
Do you mean outside of netcontrol ? I think it's fine there |
|
You also need to add the rules on api start and remove them on api stop. Use the lifetime() function from main.py for that (It's not up to date on your branch, do a |
|
Ne marche pas (les commandes ip rules sont executés dans le conteneur) |
KwikKill
force-pushed
the
netcontrol-iprules
branch
from
7b71b36
to
1abb5bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iprules.shfunctions are converted to netcontrol functionsChecklist
Related Issues
Closes #31