Add netcontrol #28
Draft
Add netcontrol #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixup1
added
enhancement
KwikKill
reviewed
Oct 18, 2024
| @@ -0,0 +1,15 @@ | |||
| FROM python:3.12-alpine3.19 | |||
There was a problem hiding this comment.
If the Dockerfile.dev is the same as the dockerfile, why not using a single file ?
There was a problem hiding this comment.
I just did this in case we needed a different setup for them later
* Added connect_user, delete_user and set_mark methods * Handled deleting non existent device exception + added logging * Add nftables documentation * Remove mark checking in backend + raise errors properly * Change add device HTTP error to 500 * Add set for backwards compatibility with nftables v1.0.6 * Fix and clean up a few things * Fix set_mark * Add ip range match * Update doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds full (or near-full) netcontrol functionnality, for managing device connections via nftables. It concerns both netcontrol itself and the components inside the backend needed to interface with it (that doesn't mean the entire Langate pipeline is working, just that the backend and netcontrol can communicate).
This also adds all the necessary documentation about netcontrol, the way it works, and the way it interfaces with the backend.
Related Issues
A number of issues need to be adressed before submitting this PR for review :
#16 #17 #18 #19 #20 #21 #22 #29
And probably some more that have not been opened yet.
Checklist